add /.well-known/matrix/server and /_matrix/federation/v1/version #61
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Telodendria/Telodendria#61
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "doesnm/Telodendria:master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Please review the developer certificate of origin:
the right to submit it under the open source licenses of the
Telodendria project; or
my knowledge, is covered under an appropriate open source license and
I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
Telodendria project license; or
who certified (1), (2), or (3), and I have not modified it.
made public and that a record of the contribution—including all
personal information I submit with it—is maintained indefinitely
and may be redistributed consistent with this project or the open
source licenses involved.
origin, and I certify that I have permission to submit this patch
under the conditions specified in it.
Overall this looks pretty good, good work! Just a few small things to clean up and then this one will be an easy merge.
@ -82,2 +82,3 @@
"federation": { "type": "boolean", "required": true },
"registration": { "type": "boolean", "required": true }
"registration": { "type": "boolean", "required": true },
"wellKnownServer": { "type": "string", "required": true }
Should this be optional? The
identityServer
is not required; if it is not provided, it defaults to a sensible value. Is it possible to do the same here?@ -125,3 +125,3 @@
size_t len;
size_t swk_len;
Cytoplasm and Telodendria use lowerCamelCase, not snake_case. See the Code Style section of the contributing document.
Please refactor this variable accordingly.
@ -363,0 +381,4 @@
HashMap *server;
response = HashMapCreate();
server = HashMapCreate();
HashMapSet(server,"name",JsonValueString("Telodendria"));
Looks like there's some odd formatting here, you might want to check your editor's whitespace settings if this was not intentional. These likes should all be flush with each other.
I'm tried to fixes all cases which you said
Through i can't use indent because it throw error for me
Ah, yeah, Telodendria assumes you're using OpenBSD's
indent
. It is on my list to fix that, since I no longer use OpenBSD very regularly. Don't worry about the formatting, I can take care of that when I merge this.